Css enhancements#1461
Open
andrewgoz wants to merge 8 commits intochartist-js:mainfrom
Open
Conversation
To customize chart colors required complicated CSS changes to do the necessary overrides. This changes makes it much easier to override colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring - the new CSS is functionally identical to the old. The primary reason for the changes is to reduce the size of the minimised CSS by nearly 20%, from 9038 bytes to 7370 bytes.
The other reason is to greatly simplify customizing series colors. Currently, the CSS styles to alter one series is:
Each additional custom series color duplicates the above over and over, adjusting for the series name.
With the new CSS variables, the required styles are:
Each additional custom series color just duplicates the one color line, adjusting for the series name.
I have also added the "ct-chart" class name to all charts, to make it easier to write CSS rules that target all charts, in the same way there is a general "ct-series" class name.