fix: preserve OpenAI OAuth prompt cache affinity#3800
Open
2314860760 wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAI OAuth requests use stateless Responses API calls and already carry the Chatbox session ID through the chat orchestration layer. However, the session ID was not propagated to OpenAI's
prompt_cache_keyoption, so consecutive requests could lose prompt-cache affinity.This change:
promptCacheKeyfor stateless OAuth Responses requests.store: falsefor OAuth requests.Testing
git diff --checkpassedThe full local suite also exposed unrelated environment-specific failures in Electron dependency installation and one Windows path-separator assertion; no failures were caused by the changed files.
Additional Notes
This uses the official OpenAI Responses API
prompt_cache_keyprovider option and does not modify OAuth endpoints, token handling, or authentication behavior.Contributor Agreement
By submitting this Pull Request, I confirm that I have read and agree to the contribution terms in the repository's PR template.