Further improvements to webxdc summary #7826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be done now as Desktop doesn't prepend icons from webxdc archives to summaries anymore.
…lay it in summary (#7790) The webxdc file name itself isn't informative for users. Still, send and display it if the webxdc manifest can't be parsed, it's better than sending "Mini App" and this isn't a normal case anyway.
iequidoo
force-pushed
the
iequidoo/webxdc-summary
branch
from
79e0776 to
f50ee44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appeared to be easier than assumed -- no new header is needed for the webxdc name, there's "filename" in the post message metadata which can be used instead. See commit messages.
Close #7790