Skip to content

feat: Group and broadcast channel descriptions #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hocuri merged 19 commits into from
Feb 10, 2026
Merged

feat: Group and broadcast channel descriptions #7829

Hocuri merged 19 commits into from
Feb 10, 2026

Conversation

@Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Feb 5, 2026 •
edited
Loading

fix #7766

Implementation notes:

  • Descriptions are only sent with member additions, when the description is changed, and when promoting a previously-unpromoted group, in order not to waste bandwith.
  • Descriptions are not loaded everytime a chat object is loaded, because they are only needed for the profile. Instead, they are in their own table, and can be loaded with their own JsonRPC call.

@Hocuri Hocuri force-pushed the hoc/chat-descriptions branch from 0480be1 to 01df608 Compare February 5, 2026 14:17
@Hocuri Hocuri changed the title [WIP] Group and broadcast channel descriptions [WIP] feat: Group and broadcast channel descriptions Feb 5, 2026
@Hocuri Hocuri force-pushed the hoc/chat-descriptions branch 2 times, most recently from 1e21677 to a2ba0e4 Compare February 6, 2026 13:39
@Hocuri Hocuri changed the title [WIP] feat: Group and broadcast channel descriptions feat: Group and broadcast channel descriptions Feb 6, 2026
@Hocuri Hocuri requested review from iequidoo, link2xt and r10s February 6, 2026 21:01
@nicodh nicodh mentioned this pull request Feb 7, 2026
Draft
iequidoo
iequidoo reviewed Feb 8, 2026
View reviewed changes
@r10s r10s mentioned this pull request Feb 8, 2026
Open
@adbenitez adbenitez mentioned this pull request Feb 9, 2026
Draft
6 tasks
@Hocuri
Copy link
Collaborator Author

Hocuri commented Feb 9, 2026 •
edited
Loading

Hang on, there is a bug that the group description isn't sent with the first message into an unpromoted group
Edit: I fixed this

Hocuri added 17 commits February 9, 2026 19:57
@Hocuri
[WIP] Group and broadcast channel descriptions
462f767
@Hocuri
Resolve some TODOs
055cc50
@Hocuri
perf: Don't load the description every time a chat is loaded
c880354
@Hocuri
Add test and fix things
ddbf8b5
@Hocuri
Don't send the group description in every message
710ac26
@Hocuri
documentation
1e33ad2
@Hocuri
Move get_chat_description() to a free function for consistency with s…
aa6e892 
…et_chat_description()
@Hocuri
Remove TODO
0caf497
@Hocuri
Remove accidentally-added whitespace
da911a9
@Hocuri
Some more fixes. Unfortunately, tests don't pass :/
2d4f123
@Hocuri
Fix timestamp problem
11de145 
The problem was inconsistent timestamp smearing:
Alice sent description updates with unsmeared timestamps.
This led Bob to reject description updates as "older" than his current group state.
@Hocuri
clippy
229c66a
@Hocuri
fix: Use correct stock string
f03fd83
@Hocuri
fix: Make GroupDescriptionTimestamp more symmetrical to GroupNameTime…
206247e 
…stamp
@Hocuri
iequidoo's review
d5e6909
@Hocuri
Rename apply_chat_name_and_avatar_changes -> apply_chat_name_avatar_a…
08dd65a 
…nd_description_changes
@Hocuri
fix: Send description when promoting a group
1c91218
@Hocuri Hocuri force-pushed the hoc/chat-descriptions branch from 8ce6bac to 1c91218 Compare February 9, 2026 18:58
@Hocuri
Copy link
Collaborator Author

Hocuri commented Feb 9, 2026

@adbenitez @nicodh if you were testing this already with a live account, then you will need to delete it, and restore from a backup or another device, because I did a rebase, changing the migration.

@nicodh
Copy link
Contributor

nicodh commented Feb 9, 2026

@adbenitez @nicodh if you were testing this already with a live account, then you will need to delete it, and restore from a backup or another device, because I did a rebase, changing the migration.

I'm not sure - so if there is a table chats_descriptions the migration was already applied and the accounts needs to be restored, correct?

@Hocuri
Copy link
Collaborator Author

Hocuri commented Feb 9, 2026

I'm not sure - so if there is a table chats_descriptions the migration was already applied and the accounts needs to be restored, correct?

Yes.

@r10s r10s mentioned this pull request Feb 9, 2026
Open
iequidoo
iequidoo approved these changes Feb 10, 2026
View reviewed changes
Hocuri and others added 2 commits February 10, 2026 22:08
@Hocuri @iequidoo
Update src/chat.rs
6330a7b 
Co-authored-by: iequidoo <117991069+iequidoo@users.noreply.github.com>
@Hocuri
fix: Ignore set_chat_description() calls that don't actually change t…
bfe3937 
…he description
@Hocuri Hocuri enabled auto-merge (squash) February 10, 2026 21:11
@Hocuri Hocuri merged commit 3fdda6f into main Feb 10, 2026
55 of 56 checks passed
@Hocuri Hocuri deleted the hoc/chat-descriptions branch February 10, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adbenitez adbenitez adbenitez left review comments

@iequidoo iequidoo iequidoo approved these changes

@link2xt link2xt Awaiting requested review from link2xt

@r10s r10s Awaiting requested review from r10s

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

channels: channel/group description

4 participants

@Hocuri @nicodh @adbenitez @iequidoo