Skip to content

chore: allow more attachment file types #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamsivin merged 5 commits into from
May 22, 2026
Merged

chore: allow more attachment file types #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91685ab
chore: allow more attachment file types
iamsivin May 14, 2026
fa1262b
chore: Minor fix
iamsivin May 14, 2026
b82622e
chore: Update version
iamsivin May 14, 2026
80d3132
chore: Clean up
iamsivin May 14, 2026
8d1d3c9
Apply suggestion from @iamsivin
iamsivin May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@chatwoot/utils",
"version": "0.0.52",
"version": "0.0.55",
"description": "Chatwoot utils",
"private": false,
"license": "MIT",
Expand Down
55 changes: 36 additions & 19 deletions src/fileUploadRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,31 +88,36 @@ type ChannelConfigs = Partial<Record<ChannelKey, ChannelConfig>> & {
* 2. channel + "*" fallback
* 3. global default
*/

const STANDARD_TEXT_MIMES = ['csv', 'plain', 'rtf', 'xml'];
const STANDARD_APPLICATION_MIMES = [
'json',
'pdf',
'xml',
'zip',
'x-7z-compressed',
'vnd.rar',
'x-tar',
'msword',
'vnd.ms-excel',
'vnd.ms-powerpoint',
'vnd.oasis.opendocument.text',
'vnd.openxmlformats-officedocument.presentationml.presentation',
'vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'vnd.openxmlformats-officedocument.wordprocessingml.document',
];
const STANDARD_EXTENSIONS = ['.3gpp', '.xls', '.xlsx'];

const CHANNEL_CONFIGS: ChannelConfigs = {
default: {
mimeGroups: {
image: ['*'],
audio: ['*'],
video: ['*'],
text: ['csv', 'plain', 'rtf', 'xml'],
application: [
'json',
'pdf',
'xml',
'zip',
'x-7z-compressed',
'vnd.rar',
'x-tar',
'msword',
'vnd.ms-excel',
'vnd.ms-powerpoint',
'vnd.oasis.opendocument.text',
'vnd.openxmlformats-officedocument.presentationml.presentation',
'vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'vnd.openxmlformats-officedocument.wordprocessingml.document',
],
text: STANDARD_TEXT_MIMES,
application: [...STANDARD_APPLICATION_MIMES, 'x-pkcs12', 'pkcs12'],
},
extensions: ['.3gpp'],
extensions: [...STANDARD_EXTENSIONS, '.pfx'],
max: 40,
},

Expand All @@ -133,6 +138,7 @@ const CHANNEL_CONFIGS: ChannelConfigs = {
'vnd.openxmlformats-officedocument.presentationml.presentation',
],
},
extensions: ['.xls', '.xlsx'],
maxByCategory: { image: 5, video: 16, audio: 16, document: 100 },
},
},
Expand Down Expand Up @@ -165,6 +171,7 @@ const CHANNEL_CONFIGS: ChannelConfigs = {
'vnd.openxmlformats-officedocument.presentationml.presentation',
],
},
extensions: ['.xls', '.xlsx'],
Comment thread
iamsivin marked this conversation as resolved.
maxByCategory: { image: 8, audio: 25, video: 25, document: 25 },
},
},
Expand All @@ -189,7 +196,17 @@ const CHANNEL_CONFIGS: ChannelConfigs = {
},

[INBOX_TYPES.TWILIO]: {
sms: { max: 5 },
sms: {
mimeGroups: {
image: ['jpeg', 'png'],
Comment thread
iamsivin marked this conversation as resolved.
audio: ['*'],
video: ['*'],
text: STANDARD_TEXT_MIMES,
application: STANDARD_APPLICATION_MIMES,
},
extensions: STANDARD_EXTENSIONS,
max: 5,
},
whatsapp: {
mimeGroups: {
image: ['png', 'jpeg'],
Expand Down
23 changes: 20 additions & 3 deletions test/fileUploadRules.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
INBOX_TYPES,
getAllowedFileTypesByChannel,
getMaxUploadSizeByChannel,
INBOX_TYPES,
} from '../src/fileUploadRules';

describe('uploadRules helper', () => {
Expand All @@ -15,6 +15,9 @@ describe('uploadRules helper', () => {
expect(accept).toContain('text/plain');
expect(accept).toContain('application/json');
expect(accept).toContain('.3gpp');
expect(accept).toContain('application/x-pkcs12');
expect(accept).toContain('application/pkcs12');
expect(accept).toContain('.pfx');
});

it('returns WhatsApp specific accept list', () => {
Expand All @@ -33,6 +36,8 @@ describe('uploadRules helper', () => {
expect(accept).not.toContain('application/json');
expect(accept).not.toContain('.3gpp');
expect(accept).not.toContain('image/gif');
expect(accept).not.toContain('application/x-pkcs12');
expect(accept).not.toContain('.pfx');
});

it('returns Instagram specific accept list', () => {
Expand Down Expand Up @@ -73,13 +78,25 @@ describe('uploadRules helper', () => {
expect(accept).not.toContain('audio/mp3');
});

it('falls back to default accept list for Twilio SMS (no mimeGroups)', () => {
it('returns Twilio SMS accept list (default-aligned, excluding PFX)', () => {
const accept = getAllowedFileTypesByChannel({
channelType: INBOX_TYPES.TWILIO,
medium: 'sms',
});
expect(accept).toContain('image/*');
expect(accept).toContain('image/jpeg');
expect(accept).toContain('image/png');
expect(accept).not.toContain('image/*');
expect(accept).not.toContain('image/gif');
expect(accept).toContain('audio/*');
expect(accept).toContain('video/*');
expect(accept).toContain('text/plain');
expect(accept).toContain('application/pdf');
expect(accept).toContain('application/json');
expect(accept).toContain('.3gpp');
expect(accept).toContain('.xls');
expect(accept).not.toContain('application/x-pkcs12');
expect(accept).not.toContain('application/pkcs12');
expect(accept).not.toContain('.pfx');
});

it('handles empty object parameter', () => {
Expand Down
Loading