Add pagination aliases, select query params and defaultIncludes#4
Open
PatrickMunsey wants to merge 2 commits into
Open
Add pagination aliases, select query params and defaultIncludes#4PatrickMunsey wants to merge 2 commits into
PatrickMunsey wants to merge 2 commits into
Conversation
…gination functionality
Author
|
Hi, I've made another commit to this pull request with the changes I made a couple of weeks ago. I've included the cursor-based functionality discussed in #5. I've been testing it out since and seems to be running smoothly and as expected. If you have any questions or want to have a more detailed discussion while reviewing, feel free to reach out. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've implemented the features discussed in #3 . I'm opening this pull request as a further point of discussion so hopefully it can be merged and shared with everyone else.
sortandorderByquery params are just concatincated in filter.parser and the orderBy Prisma query generated as before.I'll be looking into cursor based pagination next and will continue that discussion and development separately in #3 .