Add Fishpond icon#9
Open
kalinplus wants to merge 5 commits into
Open
Conversation
Owner
|
Thank you for your PR! However, to be honest, your icon doesn’t exactly match the style of the other icons. I will stick with the original icon for now while trying to find one that fits the “鱼塘”. Really appreciate your effort and the many attempts you made! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text of BBS is replaced with "鱼塘” in the index, so the original icon no longer has an effect. So, I modified the embedded base64 string, adding a fish icon to position 0xe90e, right after the original encoding. Though the icon imported from the .svg file may look slightly different from the original icons, I have tried my best to keep the style the same. I hope this modification is helpful!
Original:
Now:
