Add Сlaude Сode related entities#676
Conversation
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
RomanNikitenko
requested review from
azatsarynnyy,
rgrunber and
vitaliy-guliy
as code owners
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new Claude skill documentation at .claude/skills/add-rebase-rules/SKILL.md that, given a commit SHA or URL, resolves the commit, collects changed files, filters candidates, generates/updates .rebase/ rules (add, override, replace), inserts non-duplicate routing branches into rebase.sh, appends entries to .rebase/CHANGELOG.md, and runs validations (bash -n, jq, upstream Sequence Diagram(s)sequenceDiagram
participant User
participant ClaudeSkill as ClaudeSkill
participant Git
participant FS as FileSystem
participant Rebase as rebase.sh
participant Upstream
User->>ClaudeSkill: invoke (commit SHA or URL)
ClaudeSkill->>Git: resolve SHA
Git-->>ClaudeSkill: SHA
ClaudeSkill->>Git: git show --name-only <SHA>
Git-->>ClaudeSkill: changed files
ClaudeSkill->>ClaudeSkill: filter candidates (include/exclude)
loop per candidate
ClaudeSkill->>FS: create/update .rebase/* rule files
end
ClaudeSkill->>Rebase: insert/update routing branches (non-duplicate)
ClaudeSkill->>FS: append .rebase/CHANGELOG.md entry
ClaudeSkill->>Upstream: validate (bash -n, jq, verify `from`, Perl dry-run)
Upstream-->>ClaudeSkill: validation results
ClaudeSkill-->>User: report generated/updated rules + validation summary
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@build/dockerfiles/dev.Dockerfile`:
- Around line 21-33: Pin the google-cloud-cli package to a specific tested
release by introducing a build ARG/ENV (e.g., GCLOUD_CLI_VERSION) and replace
the floating package install (google-cloud-cli) with the versioned package name
google-cloud-cli-${GCLOUD_CLI_VERSION}; ensure the Dockerfile declares the ARG
(or ENV) before the RUN that installs, document/update the build to pass a
GCLOUD_CLI_VERSION that is one of the 10 most recent releases in the repo, and
validate the chosen version during CI/build to avoid "package not found" errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dfce47d2-e3f8-41fd-b860-8df18cf151ca
📒 Files selected for processing (3)
.claude/skills/add-rebase-rules/SKILL.mdCLAUDE.mdbuild/dockerfiles/dev.Dockerfile
|
@RomanNikitenko well done ! |
|
I tested 
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/skills/add-rebase-rules/SKILL.md:
- Around line 69-71: Update the SKILL.md multiline routing guidance to
acknowledge that rebase.sh uses two different multiline
handlers—apply_changes_multi_line and apply_multi_line_replace—so developers
should not always default to apply_changes_multi_line; instead, inspect the
target file and match the existing handler pattern (e.g., use
apply_multi_line_replace for files already handled that way, and
apply_changes_multi_line where it’s used) to ensure generated rules route to the
correct function and avoid misrouted conflicts.
In `@CLAUDE.md`:
- Around line 88-89: The documentation entry for `.rebase/replace/` is
misleadingly described as "wholesale file replacement"; update the CLAUDE.md
wording for `.rebase/replace/` to state that the rebase flow uses per-file JSON
"from"/"by" replacement rules keyed by file path (not full file swaps), give a
short example sentence like "each entry is a JSON object with 'from' and 'by'
strings applied to the specified file path", and clarify that replacements are
applied per file path rather than replacing entire files.
- Around line 113-115: The docs step instructs fetching `upstream-code main`
which mismatches how rebase.sh resolves UPSTREAM_VERSION (it expects a release
ref like upstream-code/release/1.104); update CLAUDE.md to fetch the correct
upstream branch/ref that rebase.sh uses (e.g., `git fetch upstream-code
release/1.104` or the appropriate release branch), and ensure the example aligns
with the UPSTREAM_VERSION resolution in rebase.sh so the rebase can find the
release ref.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7d0e8616-fafb-4c52-8a93-5d8fc45e7e18
📒 Files selected for processing (3)
.claude/skills/add-rebase-rules/SKILL.mdCLAUDE.mdbuild/dockerfiles/dev.Dockerfile
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Claude Code
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
RomanNikitenko
force-pushed
the
add-claude-code
branch
from
809caf9 to
d35338d
Compare
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
add-claude-code
branch
from
04c8f1c to
6ad6ca3
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@devfile.yaml`:
- Around line 133-137: The "install-claude" exec command references a
non-existent component "tools" and also directly downloads+executes an unpinned
installer without checksum; update the "install-claude" command to target an
existing component (e.g., "dev" or "KUBEDOCK_ENABLED") and change the
commandLine to pull a pinned installer URL or tag and verify its SHA256 checksum
before executing (e.g., download a specific release/archive, compare its
checksum, then chmod+run only if the checksum matches); ensure you reference the
"install-claude" id so reviewers can find and validate the corrected component
name and added checksum verification step.
- Line 136: Replace the unpinned, unverifiable installer invocation in the
commandLine that downloads claude-install.sh with a pinned and verifiable
installation flow: pin the installer version passed to the installer (e.g., use
"bash -s 2.1.89" or "bash -s stable" when invoking claude-install.sh), download
the corresponding manifest.json and manifest.json.sig for that version, import
Anthropic's release GPG key and verify the sig with GPG, compute and compare the
installed binary's SHA256 against the manifest, and set DISABLE_AUTOUPDATER=1 to
prevent runtime drift; alternatively remove the installer step and download the
specific release binary directly instead of running claude-install.sh.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c850b77b-0d63-4e51-9c7a-4077ef76b228
📒 Files selected for processing (1)
devfile.yaml
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Generated-by: Cursor AI
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-676-amd64 |
3 participants
What does this PR do?
CLAUDE.mdfileadd-rebase-rulesskillDevimage - ability to install and use Claude Code for che-code developmentWhat issues does this PR fix?
eclipse-che/che#23749
How to test this PR?
I was able to install and use Claude Code for che-code development on the dogfooding instance:
Skill for adding a rebase rule was added within current PR.
To do it:
add-rebase-rulesI tested the skill for a real task within #646:
The result was:
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderSummary by CodeRabbit
Documentation
Chores