Conversation
…ver to branch and created folder for LoyaltyPoints in src, noted what I have to do this week.
…an image for the star.
…r. made changes ralph suggested during friday meeting that fixed colour and coding practice issues.
|
https://github.com/cheapreats/react-ui-library/blob/master/src/Themes/MainTheme.ts Theme lives here, feel free to extend it with the color white if its not there |
…t guide, and corrected the errors pointed out by ralph on github.
ralph-dev
left a comment
ralph-dev
left a comment
There was a problem hiding this comment.
Why is a random package added?
|
Try removing it, then running npm install and npm start and see if application still work |
|
|
||
| export interface LoyaltyPointsProps | ||
| extends React.HTMLAttributes<HTMLDivElement>{ | ||
| LoyaltyAmount: number; |
There was a problem hiding this comment.
Why are props uppercase? With no docs
There was a problem hiding this comment.
Im having an issue with the text colour being forced to be the colour of paragraph rather than my styled div since changing to it, cant figure out how to fix that.
|
|
|
Have you tried overriding the styles? If so, maybe you need to specify a higher specificity |
|
Yeah I tried this but it didnt work, is there another way to specify a higher specificity. also I've talked to Hunter about how he did it using styled.header, but from my understanding that doesnt work does it? Im pretty sure its Heading and not header, and you have to override it with brackets not a '.' right? |
|
@percypie |
|
alright thank you, sorry I couldnt figure it out. |
|
|
2 participants
No description provided.