Support explicit GitHub Check target SHA#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-shainput that overrides event-derived SHA metadatarepository_dispatchand deployment workflows whereGITHUB_SHAdiffers from the checked-out commitWhy
Dispatch-driven validation can check out and test a commit supplied in the event payload while GitHub exposes the default-branch commit as
GITHUB_SHA. Without an override, Checkly reports the result on the wrong revision.Verification
bash -n scripts/*.shnode --check scripts/test-preflight-server.cjs./scripts/test.sh./scripts/test-integration.sh