Upgrading chefstyle to cookstyle #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Rakefile to use cookstyle binary with --chefstyle flag for main code - Update .rubocop.yml to require cookstyle instead of chefstyle - Update Gemfile to use cookstyle gem instead of chefstyle - Add Windows CRLF handling in Rakefile for cross-platform compatibility - Maintain ignore_dirs logic for excluding test fixtures from style checks - Both style tasks now use cookstyle gem with appropriate rule sets Signed-off-by: nikhil2611 <ngupta@progress.com>
All 35 cookstyle violations resolved. Tests passing: 1396 examples, 0 failures, 98.44% coverage. Signed-off-by: nikhil2611 <ngupta@progress.com>
Move begin keyword to same line as ||= operator in helpers.rb to satisfy Ruby 3.4 cookstyle requirements. Signed-off-by: nikhil2611 <ngupta@progress.com>
- Updated Rakefile to use cookstyle binary with --chefstyle flag for Ruby linting - Moved ignore patterns from Rakefile to .rubocop.yml Exclude section - Updated pipeline labels to reflect cookstyle usage - Maintains backward compatibility with existing rake style:chefstyle command - Follows Chef product's pattern for chefstyle to cookstyle migration Signed-off-by: nikhil2611 <ngupta@progress.com>
|
Simplecov Report
|
sanjain-progress
approved these changes
Jan 29, 2026
Contributor
Author
|
@Stromweld I have update here, Could you please review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving away from chefstyle to cookstyle
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.