Skip to content

fix sparse key delete when actor is removed #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justintsteele wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

fix sparse key delete when actor is removed #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da2afa
fix delete sparse key when removing a client
justintsteele Jan 20, 2026
1bbd7bb
extend spec to cover sparse key delete
justintsteele Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/chef-vault/item_keys.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ def delete(chef_key)
@cache[chef_key.name] = false
raw_data[chef_key.type].delete(chef_key.name)
raw_data.delete(chef_key.name)
unless Chef::Config[:solo_legacy_mode]
if raw_data["mode"] == "sparse"
skey = Chef::DataBagItem.load(data_bag, sparse_id(chef_key.name))
skey.destroy(data_bag, sparse_id(chef_key.name))
end
end
end

def mode(mode = nil)
Expand Down
2 changes: 2 additions & 0 deletions spec/chef-vault/item_keys_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
expect(Chef::DataBagItem.load("foo", "bar_key_client_name").to_hash).to include("id" => "bar_key_client_name")
expect(keys[client_name]).not_to be_empty
keys.delete(chef_key)
expect { Chef::DataBagItem.load("foo", "bar_key_client_name").to_hash["client_name"] }.to raise_error(Net::HTTPClientException)
keys.save("bar")
expect(keys[client_name]).to be_nil
keys.mode("default")
Expand All @@ -145,6 +146,7 @@
expect(Chef::DataBagItem.load("foo", "bar_key_client_name").to_hash).to include("id" => "bar_key_client_name")
expect(Chef::DataBagItem.load("foo", "bar_key_client_name").to_hash["client_name"]).not_to be_empty
keys.delete(chef_key)
expect { Chef::DataBagItem.load("foo", "bar_key_client_name").to_hash["client_name"] }.to raise_error(Net::HTTPClientException)
keys.save("bar")
expect(keys[client_name]).to be_nil
keys.mode("default")
Expand Down