fix preferences sync call#52
Open
rishichawda wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rishi Kumar Chawda <rishichawda@users.noreply.github.com>
rishichawda
force-pushed
the
rc/fix-preferences-sync-call
branch
from
3938b06 to
a16cae8
Compare
tpowell-progress
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preferences.setwas failing when domain, host and user is passed. CallCFPreferencesSynchronizeafterCF.CFPreferencesSetValueinstead ofCF.CFPreferencesAppSynchronizeto correctly write preference data. Also added a test case for the scenario that uncovered this bug in chef/chef repo to meet the minimum test coverage threshold of 90%Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.