Replace usage of whitelist to allowlist in code, comments and DSL#1035
Open
balasankarc wants to merge 2 commits intochef:mainfrom
Open
Replace usage of whitelist to allowlist in code, comments and DSL#1035balasankarc wants to merge 2 commits intochef:mainfrom
balasankarc wants to merge 2 commits intochef:mainfrom
Conversation
Rename the terms whitelist/blacklist in code and comments to allowlist/denylist. Note: Not changing the `whitelist_file` DSL term in this commit as it is a breaking change. It will be done in a separate commit. Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
Note: This is a breaking change. Signed-off-by: Balasankar "Balu" C <balasankarc@autistici.org>
balasankarc
force-pushed
the
rename-whitelist-allowlist
branch
from
51a5be6 to
0964181
Compare
Author
|
@tas50 How do you feel about this one, from a DIB perspective? |
lamont-granquist
approved these changes
Nov 10, 2021
Contributor
|
@balasankarc I want to make sure this gets done. I cut an issue to have one of our teams make sure we do this while also preserving the existing DSL. It would be great to throw warnings that these methods are deprecated. If you want to get this in quicker than our teams backlog feel free to update this PR with that. We can ship it as soon as we make sure the DSL doesn't immediately break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of using
whitelist,whitelist_file, etc. in code, comments and DSL, we can switch toallowlist,allow_fileetc.Note: This is a breaking change that would require a new major release. If a new major version is not on the horizon right now, we can drop the commit which changes
whitelist_filetoallow_filein this PR and do that later.Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan