feat: save to NMRium Archive v1 format #3915
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tpoisseau
commented
Jan 20, 2026
tpoisseau
commented
- remove save to json / json in zip options
* remove save to json / json in zip options
Deploying nmrium with
|
| Latest commit: |
6e823b5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4780a0ac.nmrium.pages.dev |
| Branch Preview URL: | https://561-deprecate-older-nmrium-f.nmrium.pages.dev |
Contributor
Author
|
I can't reproduce error from https://github.com/cheminfo/nmrium/actions/runs/21173563769/job/60897499181?pr=3915 in my local environment. I'm up to date with main. |
Member
|
Tests are flaky on github. I restarted the run. |
Contributor
Author
I did it some times, I'm glad this time is OK 😅 |
fix: don't throw on missing molecules
Contributor
Author
|
Draft to disable CI, need changes from core to works. |
targos
reviewed
Jan 21, 2026
src/component/1d-2d/components/FloatMoleculeStructures/FloatMolecules.tsx
Outdated
Show resolved
Hide resolved
targos
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.