Skip to content

chore: support Chrome browser checks on Windows#166

Open
syahmiharith wants to merge 1 commit into
chenglou:mainfrom
syahmiharith:codex-windows-corpus-check
Open

chore: support Chrome browser checks on Windows#166
syahmiharith wants to merge 1 commit into
chenglou:mainfrom
syahmiharith:codex-windows-corpus-check

Conversation

@syahmiharith
Copy link
Copy Markdown

Summary

  • Add a non-macOS Chrome automation path that launches headless Chrome through the DevTools Protocol instead of AppleScript.
  • Start the internal Bun page server directly through the current Bun executable instead of /bin/zsh.
  • Use the platform temp directory for browser automation locks and document the CHROME_BIN / CHROME_PATH override.

Why

Trying to follow the current TODO canary workflow on Windows failed before any browser evidence could be collected:

  • lock creation tried to use a Unix-style temp fallback
  • Chrome automation called osascript
  • page serving depended on /bin/zsh

This keeps the existing macOS Chrome/Safari behavior intact while making Chrome-based checks runnable on Windows.

Validation

  • bun run check
  • bun run corpus-check --id=mixed-app-text 710 --diagnose
  • bun run corpus-check --id=mixed-app-text 710 --diagnose --method=span
  • bun run corpus-taxonomy --id=mixed-app-text 710
  • bun run probe-check --text="hello world from pretext" --width=160

Notes

The mixed app canary at 710px is height/line-count exact in this Windows Chrome run. The diagnostic still reports a one-character break-opportunity difference around 価格は¥12,800です, so I did not make an engine change from this evidence.

@syahmiharith syahmiharith marked this pull request as ready for review May 4, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant