chore: support Chrome browser checks on Windows#166
Open
syahmiharith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/bin/zsh.CHROME_BIN/CHROME_PATHoverride.Why
Trying to follow the current TODO canary workflow on Windows failed before any browser evidence could be collected:
osascript/bin/zshThis keeps the existing macOS Chrome/Safari behavior intact while making Chrome-based checks runnable on Windows.
Validation
bun run checkbun run corpus-check --id=mixed-app-text 710 --diagnosebun run corpus-check --id=mixed-app-text 710 --diagnose --method=spanbun run corpus-taxonomy --id=mixed-app-text 710bun run probe-check --text="hello world from pretext" --width=160Notes
The mixed app canary at 710px is height/line-count exact in this Windows Chrome run. The diagnostic still reports a one-character break-opportunity difference around
価格は¥12,800です, so I did not make an engine change from this evidence.