feat: add setMeasureFunction for custom measurement backends#17
Open
intergalacticspacehighway wants to merge 2 commits into
Open
feat: add setMeasureFunction for custom measurement backends#17intergalacticspacehighway wants to merge 2 commits into
setMeasureFunction for custom measurement backends#17intergalacticspacehighway wants to merge 2 commits into
Conversation
| if (cachedEngineProfile !== null) return cachedEngineProfile | ||
|
|
||
| if (typeof navigator === 'undefined') { | ||
| if (typeof navigator === 'undefined' || typeof navigator.userAgent !== 'string') { |
There was a problem hiding this comment.
React native has a navigator object but no userAgent string 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Text). This allows us to plug pretext into non browser environments like React Native.How?
Exported
setMeasureFunctionfunction which can be used to provide a custom measure function.@shopify/react-native-skiaand custom native measurement module - https://github.com/intergalacticspacehighway/pretext-react-native-example/Test plan
Alternatives
Alternate solution for cross platform would be to polyfill the
OffscreenCanvas. This also works, can just be documented.