Fix lineCount inconsistency between layout() and layoutWithLines()#20
Open
yuribodo wants to merge 1 commit into
Open
Fix lineCount inconsistency between layout() and layoutWithLines()#20yuribodo wants to merge 1 commit into
yuribodo wants to merge 1 commit into
Conversation
walkPreparedLinesSimple was missing the isSimpleCollapsibleSpace guard that countPreparedLinesSimple has. When a trailing collapsible space overflowed the line edge, the walk path treated it as a line break via canBreakAfter instead of letting it hang past the edge per CSS white-space: normal semantics. This caused layoutWithLines() to report a higher lineCount than layout() for inputs where content after the hanging space would still fit on the same line. Fixes chenglou#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
walkPreparedLinesSimplewas missing theisSimpleCollapsibleSpaceguard thatcountPreparedLinesSimplealready hascanBreakAfter) instead of letting it hang past the edge per CSSwhite-space: normalsemanticslayoutWithLines()to report a higherlineCountthanlayout()for inputs where content after the hanging space would still fit on the same lineFixes #11
Test plan
bun run checkpasses (tsc + oxlint)bun testpasses (61/61, was 60)