Add French language support to editorial demos#23
Open
ambershen wants to merge 1 commit into
Open
Conversation
Both dynamic-layout and editorial-engine demos now read a ?lang=fr URL
parameter to switch headline, body, pullquote, and hint text to French
with proper typographic conventions (NNBSP, guillemets, curly apostrophes).
Uses setLocale('fr') to retarget the word segmenter. Demo index page
gets small FR links below each supported card.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?lang=frURL parameter support to both the dynamic-layout and editorial-engine demosdynamic-layout-text-fr.ts,editorial-engine-text-fr.ts) with proper French typographic conventions (U+202F before:;!?, guillemets, curly apostrophes)setLocale('fr')to retargetIntl.Segmenterfor French word boundariesTest plan
bun start→ openlocalhost:3000/demos/dynamic-layout(English) and?lang=fr(French)bun start→ openlocalhost:3000/demos/editorial-engineand?lang=frbun run check— typecheck + lint passesbun test— existing tests still pass🤖 Generated with Claude Code