fix(core): add flock to serialize session file read/write#325
Open
fix(core): add flock to serialize session file read/write#325
Conversation
Adds exclusive advisory file locking to SessionManager.load() and SessionManager.saveLocked() using flock(2). This prevents race conditions when multiple projects or goroutines concurrently access the same session state file, ensuring counter/sessions/active_session are always consistent. Fixes #324. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Note: CI lint check failed with the following errors: Please consider handling the error return values from |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flock(2)toSessionManager.load()andSessionManager.saveLocked(){storePath}.lock- acquired exclusively before read/writeFixes #324.
Test plan
go build ./...passesgo vet ./...passesgo test ./...passesCloses #324