Refactor TimerQueue to use unique_ptr and sequence-based indexing.#737
Open
Sakura1221 wants to merge 1 commit into
Open
Refactor TimerQueue to use unique_ptr and sequence-based indexing.#737Sakura1221 wants to merge 1 commit into
Sakura1221 wants to merge 1 commit into
Conversation
- Own Timer objects in timerMap_; index expiration/active sets by timer id - Create and destroy Timer on the event-loop thread (addTimer posts runInLoop; timerMap_ cleared in ~TimerQueue on loop thread) - Issue TimerId from nextTimerId_; construct Timer inside addTimerInLoop only - TimerId holds sequence only (no Timer*); cancel uses sequence - Assert timerMap find on paths that require the timer to exist Public EventLoop timer API unchanged. Timer.h unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public EventLoop timer API unchanged. Timer.h unchanged.