Fix/region toggle multi folder, remove finished searches from settings#918
Merged
volodkindv merged 3 commits intoJul 9, 2026
Merged
Conversation
When a display name maps to multiple folder IDs (e.g., Москва и МО – Завершенные поиски → 411, 412, 415), the toggle must cover ALL of them. Previously only a single folder_id was used (MIN from grouped query in MAX bot, or last-wins iteration in VK bot), causing a stale checkmark loop: - _get_subscribed_region_names showed checkmark (matched another folder_id) - toggle only operated on the single known folder_id - clicking could never fully unsubscribe Fixes: - toggle_region_by_name: check all folder_ids, subscribe/unsubscribe all - MAX bot on_paginate_toggle: build folder_dict from full folder list - VK bot _toggle_region_inline: accumulate folder_ids per name
0ce45bd to
e5b16dc
Compare
Users should only subscribe to active searches and info support. - Filter out folder_subtype='searches finished' in get_geo_folders() and get_geo_folders_by_district() queries - Add migration 010 to clean up existing finished-search subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.