fix(compose_notifications): use ON CONFLICT DO NOTHING to prevent UnqueViolation#921
Merged
volodkindv merged 1 commit intoJul 10, 2026
Conversation
…queViolation batch_insert_notifications now uses INSERT ... ON CONFLICT DO NOTHING on the partial unique index notif_by_user_unique_unsent_idx. This atomically skips duplicate records that arise from: - YMQ redelivery of compose_notifications pub/sub messages - Race conditions when call_self_if_need_compose_more re-triggers before the current change_log is marked 'y' Previously, flush_batch had DOUBLING_DIAG checks that only logged warnings but still attempted the insert, causing 502 errors on production (IntegrityError crash in compose_notifications). Also replaced the per-record diagnostic queries with a single inserted-vs-skipped log message, reducing N queries per batch to 1. Fixes the 502 errors observed for resource_id d4edldufbefp11r92d94.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batch_insert_notifications now uses INSERT ... ON CONFLICT DO NOTHING on the partial unique index notif_by_user_unique_unsent_idx. This atomically skips duplicate records that arise from:
Previously, flush_batch had DOUBLING_DIAG checks that only logged warnings but still attempted the insert, causing 502 errors on production (IntegrityError crash in compose_notifications).
Also replaced the per-record diagnostic queries with a single inserted-vs-skipped log message, reducing N queries per batch to 1.
Fixes the 502 errors observed for resource_id d4edldufbefp11r92d94.