Build out new reservation flow for members

[jim]

What it does

• Renames "group lending" throughout the system to "reservable items" to better reflect the use cases.
• Provides the UI for members to reserve items and associate them with appointments. This includes the concept of a "current reservation" which we'll probably want to tweak the language on. But it provides a cart-like interface for adding items to a reservation and then requesting them. The existing system tests for reservations were updated to cover these changes.
• Updates the dev data to have reservable items, etc. to make it easier to develop these features.

[crismali]

Just a few little things but I think it looks good. 🔥

The main thing is that there is some nil handling after ActiveRecord finds which I think raise errors if the record can't be found.

[crismali]

CI fails on this assertion because it's looking for "March 01" but the page contains "March 1" which means that formatted_date_only helper function likely needs to be tweaked.

[jim]

We already have a :month_day_year option that removes the leading zero it turns out!

[crismali]

If this is only used in the one place it might make sense to just put it inline in the index.html.erb for now.

[crismali]

I think this will raise if it can't find the reservation, so the if on the next few lines may not be necessary. Maybe a rescue_from is more appropriate? Or a find_by(id: reservation_hold_params[:reservation_id])

[jim]

Good call. I think I was trying to have some of the error handling redirect the user to different places, but it's really just a safeguard and shouldn't really be hit anyway. I'll simplify it using rescue_from.