Skip to content

Handle authorization error when renewing a stale loan #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jim merged 1 commit into from
Mar 27, 2026
+8 −6
Merged

Handle authorization error when renewing a stale loan #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/account/renewals_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ def create

renew_loan(@loan)
redirect_to account_loans_path, success: "#{@loan.item.name} was renewed.", status: :see_other
rescue Pundit::NotAuthorizedError
redirect_to account_loans_path, warning: "This loan can no longer be renewed.", status: :see_other
end
end
end
12 changes: 6 additions & 6 deletions test/controllers/account/renewals_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ class RenewalsControllerTest < ActionDispatch::IntegrationTest
end

test "member cannot renew a non-renewable loan" do
assert_raises Pundit::NotAuthorizedError do
post account_renewals_url(loan_id: @loan1)
end
post account_renewals_url(loan_id: @loan1)
assert_redirected_to account_loans_url
assert_equal "This loan can no longer be renewed.", flash[:warning]
end

test "member cannot renew another member's loan" do
assert_raises Pundit::NotAuthorizedError do
post account_renewals_url(loan_id: @loan2)
end
post account_renewals_url(loan_id: @loan2)
assert_redirected_to account_loans_url
assert_equal "This loan can no longer be renewed.", flash[:warning]
end
end
end
Loading