Open
Conversation
…isualizations into distribution-locations
…o locations_updated.csv
…visualizations into distribution-locations
…visualizations into distribution-locations These can merge!
Collaborator
Author
|
distribution-locations for review! |
Collaborator
|
Could you remove any unnecessary files/code? Specifically, remove |
Collaborator
Author
|
Deleted original locations.csv and updated name of locations_updated.csv to locations.csv |
asteinhart
reviewed
Apr 10, 2025
maroon-map/package.json
Outdated
Contributor
There was a problem hiding this comment.
i dont think this folder needs to be added, is that right?
asteinhart
reviewed
Apr 10, 2025
Contributor
There was a problem hiding this comment.
did you need to add a new package to npm? if not, lets remove the package.json and package-loc.json files changes on this pr pls!
Collaborator
Author
There was a problem hiding this comment.
Ope! Sorry, I don't think I mean to add that folder nor the packages within it in the first place. Will remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was the functionality tested and verified?
All steps should be completed in the order presented, and you should not move on to the next step until the previous is completed.
htmlpage is the same as the chart title.meta_data.jsonfile for each visual is filled in correctly (the description is a complete sentence, and the title is the same as the visual).npm run process-visualcommand.