Removing state pollution in init_ExpStock.__next__()#18
Open
sturmianseq wants to merge 1 commit intochie8842:masterfrom
Open
Removing state pollution in init_ExpStock.__next__()#18sturmianseq wants to merge 1 commit intochie8842:masterfrom
init_ExpStock.__next__()#18sturmianseq wants to merge 1 commit intochie8842:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve test reliability of test
test_append_paramby removing state pollution ininit_ExpStock.__next__()by making a deep copy.The test can fail in this way by running
pip3 install pytest-repeat; python3 -m pytest --count=2 expstock/test_expstock.py::test_append_param:It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state pollution.