Second try at header stabilization#10
Open
MitchBradley wants to merge 4 commits intochilipeppr:masterfrom
Open
Second try at header stabilization#10MitchBradley wants to merge 4 commits intochilipeppr:masterfrom
MitchBradley wants to merge 4 commits intochilipeppr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version uses pull-right and pull-center decorations on
I did see strange behavior from a Cloud 9 live preview in a case where widget.html had been modified but not saved. It seemed that the live update got confused. Saving the file and reloading cleared up the problem. I have not seen any problems when loading a properly-saved file.
In this version, I dispensed with the attempt to create a minimal-visual-diff patch. Instead, I used strict and consistent indentation for all elements inside the affected code, making is easier to verify the containment hierarchy.