P0: Project scaffolding and foundations#6
Merged
Conversation
Implements milestone P0 (#1–#5): - Go module + package layout (cmd/macvz-kubelet, pkg/{runtime,provider, network,config,metrics}, internal/{types,version}) - CLI entrypoint with flags, YAML config loading, klog logging, --version - runtime.Runtime interface + provider.Provider stub implementing virtual-kubelet node.PodLifecycleHandler (compile-time asserted) - CI workflow (build/vet/test/lint) on macOS Apple Silicon runners - Makefile with ldflags version stamping; example config Pins virtual-kubelet v1.12.0 + k8s.io v0.35.0 (requires Go 1.25). Closes #1 Closes #2 Closes #3 Closes #4 Closes #5 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
golangci-lint v1.64.8 (Go 1.24) cannot lint a go 1.25 module. Pin golangci-lint-action@v7 + v2.10.1, add v2 config, gofmt struct alignment. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements milestone P0 — Scaffolding & Foundations.
What's included
github.com/chimerakang/macvz) + package layout;.editorconfigmacvz-kubeletCLI:--config/--versionflags, YAML config loader (pkg/config), klog loggingruntime.Runtimeinterface +provider.Providerstub implementing virtual-kubeletnode.PodLifecycleHandler(compile-time asserted)macos-15(build / vet / test -race / golangci-lint)Makefilewith ldflags version stamping;config.example.yamlVerification (local)
go build ./...,go vet ./...,go test ./...— greengolangci-lint run(v2.10.1) — 0 issuesmake buildproduces a stampedbin/macvz-kubelet;--versionprints build metadataNotable decision
virtual-kubelet v1.12.0pinsk8s.io v0.35.0and requires Go 1.25 (issue #1 assumed 1.23+). Pinned the full matrix to avoid version skew betweenclient-goandk8s.io/api. Thego.modgodirective is1.25.0; CI usesgo-version-file: go.mod.The provider depends only on the
runtime.Runtimeinterface, never a concrete driver — keeping P1 (runtime impl) and P2 (provider logic) independently buildable.🤖 Generated with Claude Code