-
-
Notifications
You must be signed in to change notification settings - Fork 0
Addressing PR comments + fix Google Gemini tool schema compatibility #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,374
−222
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
819ef7b
feat: add Exa HTTP MCP, Telegram MarkdownV2, and real LLM streaming
Copilot dd9316c
fix: address code review — fix inefficient lines().count() in loop, c…
Copilot f9a3250
feat: stream tool status always + MarkdownV2 on all command sends
Copilot 84bebc4
fix: backslash first in SPECIAL_CHARS_V2, rename misleading test
Copilot d2f4a23
fix: guard find_unescaped against non-char-boundary slice on multi-by…
Copilot 8defacd
feat: human-readable tool names and entity-based markdown rendering
Copilot bf2894f
fix: log warning for invalid markdown link URLs
Copilot 21b8f65
feat: add query rewriter disable by default with /query-rewrite toggl…
Copilot ba11f70
fix(llm): parse Kimi native tool-call format leaked into content field
Copilot 3bf66d8
fix(llm): replace chat_stream() with stream_text() to prevent truncat…
Copilot 727ab00
fix: remove fragile source-scanning guard test, keep behavioral strea…
Copilot 969804b
Update agent.rs
chinkan 71d664f
fix: address code review - fix MCP tool parsing, O(n²) perf, paragrap…
Claude 1e79161
fix: sanitize tool parameter schemas for Google Gemini compatibility
Copilot adbb36e
fix: enhance sanitize_parameters for Google Gemini compatibility - em…
Copilot 47a57ae
fix: improve tool message UX — delete verbose status on finish, add t…
Copilot 88e50e4
fix: unwrap single-variant unions in sanitize_parameters, fix utf16_t…
Copilot 77125e4
refactor: rename should_unwrap to variant_count for clarity
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When verbose mode is enabled, tool progress is already shown via
ToolCallNotifier(separate “⏳ Working…” message). This additional streaming of tool status lines into the main response token stream will duplicate the tool UI and permanently prepend status lines to the final assistant message. Consider choosing a single mechanism (either keep the notifier message, or stream status into the main message and disable the notifier for that mode).