React.PropTypes, React.createClass replaced for RN 0.49+#33
Closed
fungilation wants to merge 1 commit intochirag04:masterfrom
fungilation:master
Closed
React.PropTypes, React.createClass replaced for RN 0.49+#33fungilation wants to merge 1 commit intochirag04:masterfrom fungilation:master
fungilation wants to merge 1 commit intochirag04:masterfrom
fungilation:master
Conversation
fungilation
changed the title
fungilation
changed the title
adlenafane
approved these changes
Oct 17, 2017
|
@chirag04 Hope you'll have some time to review this. It's a blocker with RN 0.49. Thanks |
wwwdata
approved these changes
Oct 24, 2017
chirag04
reviewed
Oct 24, 2017
| "onDidClearAllBookmarksEmitter": {}, | ||
| "onDidAddBookmarkEmitter": {}, | ||
| "onDidRemoveBookmarkEmitter": {}, | ||
| "onDidUpdateBookmarkEmitter": {}, |
chirag04
reviewed
Oct 24, 2017
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| asap@~2.0.3: |
Author
There was a problem hiding this comment.
Disagree about removing this one. I use yarn, it's gaining popularity, I think it's better than npm and it's a drop-in replacement. Doesn't hurt to have the file, can be ignored if not using.
Owner
|
just 2 nits and we can ship this. ideally we switch everything to es6 classes but it's fine for now |
Author
|
@chirag04 how about you make the call for what you want to merge. Merge this and then you can delete "offending" files as you wish. |
|
Can either this PR or #32 possibly get merged soon, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30, #31
Redbox errors otherwise.