Skip to content

Update Dmod_SetEnv function implementation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAmadis merged 3 commits into from
Nov 7, 2025
Merged

Update Dmod_SetEnv function implementation #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09fec96
Initial plan
Copilot Nov 7, 2025
d08314f
Update Dmod_SetEnv to match new DMOD API signature
Copilot Nov 7, 2025
242d429
Improve documentation clarity for Dmod_SetEnv return value
Copilot Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/dmenv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,17 +467,32 @@ DMOD_INPUT_API_DECLARATION(dmenv, 1.0, size_t, _count, (dmenv_ctx_t ctx))
*
* @param Name Name of the environment variable
* @param Value Value to set
* @return bool true if successful, false otherwise
* @param Overwrite If non-zero, overwrite existing variable; if zero, keep existing value
* @return int 0 if successful, -1 otherwise
*/
DMOD_INPUT_API_DECLARATION(Dmod, 1.0, bool, _SetEnv, (const char *Name, const char *Value))
DMOD_INPUT_API_DECLARATION(Dmod, 1.0, int, _SetEnv, (const char *Name, const char *Value, int Overwrite))
{
dmenv_ctx_t ctx = dmenv_get_default();
if (ctx == NULL)
{
DMOD_LOG_ERROR("No default context set for Dmod_SetEnv\n");
return false;
return -1;
}

// If Overwrite is 0 and variable already exists, return success without updating
if (Overwrite == 0)
{
const char *existing = dmenv_get(ctx, Name);
if (existing != NULL)
{
DMOD_LOG_VERBOSE("Variable %s already exists, not overwriting\n", Name);
return 0;
}
}
return dmenv_set(ctx, Name, Value);

// Set or update the variable
bool result = dmenv_set(ctx, Name, Value);
return result ? 0 : -1;
}

/**
Expand Down