Complete dmramfs implementation and update CI for RAM filesystem#3
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
…ling Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
JohnAmadis
left a comment
There was a problem hiding this comment.
@copilot zacommitowałeś pliki, które są generowane i pliki binarne - usuń je proszę, zacommituj usunięcie, a następnie dodaj do gitignore
The codeql build artifacts were already removed in commit |
|
@copilot testy crashują - jest jakiś segmentation fault na CI: |
…ty root paths Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
... Fixed in commit
All 13 fs_tester tests now pass. |
|
|
||
| ## Usage | ||
|
|
||
| The module can be loaded and mounted using DMVFS: |
There was a problem hiding this comment.
Dodaj jeszcze informacje, że moduł ten wymaga biblioteki systemowej dmlist
Oraz sprawdź czy to normalne że fs_tester pomimo przechodzenia testów drukuje błąd o problemach z zamknięciem pliku
There was a problem hiding this comment.
Added the dmlist dependency information in commit 73a3d16.
Regarding the fclose errors: they appear because dmvfs checks if (!fclose_func(...)) expecting boolean (non-zero = success), but DMFSI convention uses 0 (DMFSI_OK) for success. This is a mismatch in dmvfs, not dmramfs. The file operations work correctly - tests pass because the actual cleanup still happens. I documented this in the "Known Issues" section.
…n README Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
dmlist_insertreturn value check (returns bool, not error code)/test.txtFixes: The tests were crashing because:
dmlist_insertreturnstrueon success but the code was checking!= 0expecting error codes/test.txtcreated empty directory components that weren't handledAll 13 fs_tester tests now pass.
Known Issue: The
[ERROR] Failed to close filemessages appear due to a return value convention mismatch between dmvfs (expects boolean) and DMFSI (uses 0 for success). Tests pass correctly despite these messages.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.