Update models.py#139
Open
jacksonjacobs1 wants to merge 1 commit into
Open
Conversation
Image names within a project should be unique
There was a problem hiding this comment.
Pull request overview
This PR aims to enforce unique image names within a project at the database level to prevent collisions during annotation import/QA matching and accidental duplicate uploads.
Changes:
- Add a
(project_id, name)uniqueness constraint to theimagetable. - Minor formatting/indentation adjustment in
get_model_column_names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| notifications = relationship("Notification", backref='image', lazy=True) | ||
|
|
||
| __table_args__ = ( | ||
| UniqueConstraint('project_id', 'name', name='uq_image_project_name'), |
Comment on lines
+66
to
+68
| __table_args__ = ( | ||
| UniqueConstraint('project_id', 'name', name='uq_image_project_name'), | ||
| ) |
Comment on lines
216
to
+219
| Returns: | ||
| List[str]: A list of column names. | ||
| """ | ||
| return [getattr(model, column.name) for column in model.__table__.columns] No newline at end of file | ||
| return [getattr(model, column.name) for column in model.__table__.columns] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image names within a project should be unique.
We should also consider implementing similar idempotent behavior for existing annotation uploads and tissue mask generation