Open
Conversation
375d76b to
f750a4b
Compare
Owner
|
This is very interesting! Are you sure that it follows the Monad laws though? Some examples would be great. |
Contributor
Author
|
Oops. I didn't mean to close it. |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #4 to use
Codec'as aMonad.This allows to parse formats that are prefixed with some metadata that determines the rest of the encoding. For instance, a bytestring can be encoded with its length first:
I have put this in a separate PR because it is a breaking change.
Codec'has a slightly different definition;Functor fwconstraint).While #4 is not strictly required for the instance, the ability to (co)map over the
wparameter is crucial to make that instance usable.If you are interested in merging this, I can write some documentation about how to use write monadic
Codecs before that happens.