Skip to content

build: migrate to ESLint 9 flat config - #23

Merged
chrisae9 merged 7 commits into
devfrom
codex/eslint9-migration
Aug 7, 2026
Merged

build: migrate to ESLint 9 flat config#23
chrisae9 merged 7 commits into
devfrom
codex/eslint9-migration

Conversation

@chrisae9

@chrisae9 chrisae9 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • migrate from unsupported ESLint 8 and eslint-config-airbnb-base to ESLint 9 flat configuration
  • preserve Airbnb correctness behavior with supported core and Stylistic replacements
  • lint all first-party JavaScript and Vue files with separate browser, test, and Node globals
  • enforce zero lint warnings and clean up existing Vue/test lifecycle findings

Dependency status

  • removes every deprecated direct dependency from the install graph
  • remaining deprecation notices are upstream transitives from Babel CLI and Vue Test Utils
  • major framework/runtime upgrades remain separate migration PRs

Verification

  • clean install, production build, 153 Node tests, 235 Vitest tests, warning-free whole-repository lint, zero-vulnerability audit, and clean diff check
  • Mac mini ARM64, exact commit de193d5345d2233a928321f25c965fd704155393: clean install, production build, 153 Node tests, 235 Vitest tests, warning-free whole-repository lint, zero-vulnerability audit, and clean diff check
  • independent review found and verified bounded cleanup for signal-terminated child processes; CodeRabbit incremental review is currently rate-limited

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chrisae9, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 63f4f409-2178-4c19-850f-4f6e47db604f

📥 Commits

Reviewing files that changed from the base of the PR and between 5358b04 and de193d5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json, !package-lock.json
📒 Files selected for processing (18)
  • .eslintrc.js
  • eslint.config.mjs
  • package.json
  • server.js
  • src/__tests__/vuetify3-migration.test.js
  • src/components/PlexItem.vue
  • src/components/PlexMediaPlayDialog.vue
  • src/components/PlexThumbnail.vue
  • src/components/TheSidebarRight.vue
  • src/views/PlexLibrary.vue
  • src/views/RoomJoin.vue
  • src/views/WebPlayer.vue
  • test/cache.test.js
  • test/combineurl.test.js
  • test/kick.test.js
  • test/server.test.js
  • test/socket-validation.test.js
  • vite.config.js

Comment @coderabbitai help to get the list of available commands.

@chrisae9
chrisae9 marked this pull request as ready for review August 7, 2026 03:18
@chrisae9
chrisae9 merged commit 1c9a944 into dev Aug 7, 2026
11 checks passed
@chrisae9
chrisae9 deleted the codex/eslint9-migration branch August 7, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant