Skip to content

build: use Shaka production bundle - #26

Merged
chrisae9 merged 1 commit into
devfrom
codex/shaka-production-bundle
Aug 8, 2026
Merged

build: use Shaka production bundle#26
chrisae9 merged 1 commit into
devfrom
codex/shaka-production-bundle

Conversation

@chrisae9

@chrisae9 chrisae9 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • use Shaka Player's production UI distribution in the application and custom controls
  • update the affected unit-test mock
  • remove the Shaka eval warning from production builds
  • reduce the WebPlayer chunk from 1,969.33 kB to 1,115.62 kB raw (43.4%) and from 447.67 kB to 344.55 kB gzip (23.0%)

Verification

  • npm ci
  • npm run lint
  • npm test (162 Node tests and 242 Vitest tests)
  • npm audit (0 vulnerabilities)
  • targeted player/UI tests (28 tests)
  • confirmed no debug Shaka imports or generated WebPlayer eval() remain

Draft while Mac mini validation and CodeRabbit review run.

@chrisae9

chrisae9 commented Aug 8, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chrisae9, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d5fa525a-6a9d-4216-a7ab-59ffc449d759

📥 Commits

Reviewing files that changed from the base of the PR and between ffd64fc and a48168e.

📒 Files selected for processing (16)
  • src/__tests__/subtitle-menu-registration.test.js
  • src/player/init.js
  • src/player/ui/buttons/closebutton.js
  • src/player/ui/buttons/forward30button.js
  • src/player/ui/buttons/manualsyncbutton.js
  • src/player/ui/buttons/nextbutton.js
  • src/player/ui/buttons/previousbutton.js
  • src/player/ui/buttons/replay10button.js
  • src/player/ui/menus/audioselection.js
  • src/player/ui/menus/bitrateselection.js
  • src/player/ui/menus/mediaselection.js
  • src/player/ui/menus/subtitlecolorselection.js
  • src/player/ui/menus/subtitleoffsetselection.js
  • src/player/ui/menus/subtitlepositionselection.js
  • src/player/ui/menus/subtitleselection.js
  • src/player/ui/menus/subtitlesizeselection.js

Comment @coderabbitai help to get the list of available commands.

@chrisae9
chrisae9 marked this pull request as ready for review August 8, 2026 06:50
@chrisae9
chrisae9 merged commit c4f9a01 into dev Aug 8, 2026
9 checks passed
@chrisae9
chrisae9 deleted the codex/shaka-production-bundle branch August 8, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant