This repository was archived by the owner on Jan 10, 2021. It is now read-only.
Enable running rake target without argument all#23
Open
Letme wants to merge 1 commit intochrisanthropic:masterfrom
Open
Enable running rake target without argument all#23Letme wants to merge 1 commit intochrisanthropic:masterfrom
Letme wants to merge 1 commit intochrisanthropic:masterfrom
Conversation
Now when you run `rake pdf` it does not build all the books, but throws some strange error. I realize that you should run `rake pdf[all]` but I think it is implied that `rake pdf` should be called for all books. It is a simple check if the book argument is null, then also consider it in all target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now when you run
rake pdfit does not build all the books, but throwssome strange error (actually it builds jekyll and then fails with wrong filename). I realize that you expect to run
rake pdf[all], but Ithink it is implied that
rake pdfshould be called when you want to build for all books.It is a simple check if the book argument is null, then also consider it in all target.