This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Closed
Conversation
Owner
|
Hi, thanks for the PR! Unfortunately Snapper is now deprecated: https://github.com/chrisbanes/snapper#deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for experimental ios/uikit. I tried to take a similar approach to this pull request as is in #7 to make the potential merge as simple as possible. Pull request was tested locally by forking the accompanist pager library, and it worked. Unfortunately compose test artifacts are missing for uikit, so tests could not be setup.
There are still some issues that need to be resolved before this could potentially be merged:
:libmodule, so I'm not yet sure what is happening there.