Refactor cli logic and add multiple features#46
Open
prime-run wants to merge 1 commit intochrishrb:mainfrom
Open
Refactor cli logic and add multiple features#46prime-run wants to merge 1 commit intochrishrb:mainfrom
prime-run wants to merge 1 commit intochrishrb:mainfrom
Conversation
Owner
|
many thanks for this PR! Will look into it the next few days 👍 |
|
Pretty sweet. You can avoid breaking backwards compatibility with the existing way of running go-grip by implementing This is in fact the calling convention used by the original Python-based grip to write the rendered Markdown to a file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors and redesigns the
cliimplementation.Also implements the
plannedfeature to export the generated HTML (#44),Added Features :
mdfiles rendering + a simple index pageNOTE: as you see this PR has a single commit, the reason is I commited the built
binaryand after removing it's index from history (~root) realized I had the repo fully cloned (mistook my original clone for a--depth=1as I alsmost always perform a shallow clone). And well you know what it means I guess!Anyways in case you are intrested in actual commit history of this pr, here they are (after c446496 )