titles in <pre> for better browser compatibility#180
Merged
cjyetman merged 1 commit intochristophergandrud:masterfrom Mar 18, 2017
cjyetman:sankey-title-tooltips-in-<pre>
Merged
titles in <pre> for better browser compatibility#180cjyetman merged 1 commit intochristophergandrud:masterfrom cjyetman:sankey-title-tooltips-in-<pre>
cjyetman merged 1 commit intochristophergandrud:masterfrom
cjyetman:sankey-title-tooltips-in-<pre>
Conversation
This was referenced Mar 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the sankey plot put its multi-line title/tooltip strings inside a
<pre>tag, which seems (after some experimentation by @cjyetman) to have the broadest browser compatibility (i.e. it actually works in IE11/Windows7, and doesn't break functionality in recent versions of Chrome, Firefox, and Safari)This PR resolves issue #175 and #146, and supersedes PR #152, as well as address one of the issues with PR #130