Route default Foundation Models through Conduit#71
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ae1df632f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let bridge = ConduitInferenceProvider( | ||
| provider: provider, | ||
| model: .foundationModels, | ||
| supportsStreamingToolCalls: false | ||
| ) |
There was a problem hiding this comment.
Disable tool-call streaming path, not just capability flag
Setting supportsStreamingToolCalls: false here only changes reported capabilities; it does not prevent the provider from being treated as a streaming tool-call provider. ConduitInferenceProvider still conforms to ToolCallStreaming*, and Agent.executeToolCallingLoop decides useToolStreaming from protocol conformance (see Agent.swift around structuredToolStreamingProvider/promptToolStreamingProvider), so the default Foundation Models route will still enter generateWithToolsStreaming whenever streaming+observer are enabled. That means the new Foundation Models default can still take the streaming path you intended to disable, which can drop tool execution if streaming tool-call completion events are unavailable.
Useful? React with 👍 / 👎.
Summary
Verification