This repository was archived by the owner on Oct 10, 2024. It is now read-only.
Add title attribute to option links for screen readers and tooltips.#3
Open
lucidmachine wants to merge 1 commit into
Open
Add title attribute to option links for screen readers and tooltips.#3lucidmachine wants to merge 1 commit into
lucidmachine wants to merge 1 commit into
Conversation
Owner
|
I like this in theory, but I'm not sure I'm comfortable merging it right away without more research. My initial impression from some cursory searches is that the title tag is not necessarily ideal for a11y. A better alternative might be modifying Open to hearing from a11y pros... any thoughts @grayghostvisuals? |
Owner
|
Additional question: is it possible to get the benefits of the tooltip (because I personally like tooltips and think they're beneficial for visually-abled users) without the screen reader downsides? Is it a question of title tag + aria-label? Something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current widget's options are read only as "link" by screenreaders. Copying each option's span text to its anchor's title attribute allows screenreaders to read each option anchor and creates a tooltip for each icon.