Harden artifact verification and publish DeepSeek evaluation - #42
Merged
Conversation
chriswu727
marked this pull request as ready for review
July 16, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
required_artifactsacceptance contract to the API and desktop formdeepseek-chatrun: 12/12 solved, 0 false acceptances, 39 steps, 64,447 provider-reported tokens, 94.954 secondsWhy
The first real-provider run exposed two false acceptances: verification commands generated expected artifacts only inside a temporary verification copy, while Loop accepted the task even though the final workspace did not contain those files. After making the artifact requirement explicit, a second issue appeared: correct contract-backed work could be rejected by a redundant agent-proposed check. This change fixes both failure modes at the acceptance-engine level.
Impact
Required final outputs are now visible, independently enforced, included in Receipts, and replayable. Verification checks cannot depend on mutations made by earlier checks. The recorded evaluation is deliberately labeled as one clean local
inlinereduced-isolation run, not a production-sandbox or cross-model claim.Validation
make check— ruff, mypy, JS lint/typecheck/tests, 420 API tests