Harden cancellation, recovery, and concurrency - #51
Merged
Conversation
chriswu727
marked this pull request as ready for review
July 21, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Cancellation previously only became visible between agent steps, a cancelled host command could leave descendants running, and a worker crash between a tool side effect and Step persistence could repeat a mutation. Stale lock eviction could also remove a legitimate long-running project lock. These gaps made duplicate delivery and recovery unsafe despite the durable queue.
The new boundary is intentionally at-most-once: Loop records an operation before execution, clears it with the hash-chained Step, and fails closed when the outcome is unknowable.
Validation
The real Redis restart and k3d Postgres interruption harnesses run in required GitHub CI; the local Docker daemon was unavailable.