Ship versioned Product Sessions#57
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2f9536377
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prior_snapshot.patch, | ||
| ) | ||
| task.workspace_path = str(destination.resolve()) | ||
| original.superseded_by_id = task.id |
There was a problem hiding this comment.
When a user creates v2, this immediately marks v1 as superseded, so inspect_change_set refuses v1 Apply and create_revision refuses further feedback on v1. If the new revision later fails, is cancelled, or is discarded before reaching execution-verified completion, the session has no applyable verified latest and cannot create another successor because v2 does not satisfy the completion gate. Consider only superseding the previous delivery after the successor is verified, or provide a recovery path that reopens v1 when the successor does not become a delivery.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
make check— API 551, Web 21, Desktop 14 passedpnpm buildpnpm --filter web test:e2e— 1 passedmake audit— no known vulnerabilities