Skip to content

Fix response truncation for messages >4KB on Windows named-pipes#112

Merged
dominiquefc merged 1 commit into
chromium:mainfrom
ehomsi-google:fix
Jun 25, 2026
Merged

Fix response truncation for messages >4KB on Windows named-pipes#112
dominiquefc merged 1 commit into
chromium:mainfrom
ehomsi-google:fix

Conversation

@ehomsi-google

@ehomsi-google ehomsi-google commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Without the fix, final_size remains 0 during partial chunk reads (ERROR_MORE_DATA).

As a result:

  1. Subsequent ReadFile calls write to buffer.data() + 0 (overwriting previously read chunks).
  2. The final buffer.resize(final_size) truncates the entire buffer to the size of the last chunk, corrupting the message.

As well as do follow up fixes for adding copied data enum

Small fixes
@ehomsi-google ehomsi-google changed the title Small fixes Fix response truncation for messages >4KB on Windows named-pipes Jun 25, 2026
@dominiquefc
dominiquefc merged commit 2a8191a into chromium:main Jun 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants