Skip to content

TIPCommon update: Gitsync#515

Open
gnishant-gupta wants to merge 18 commits intomainfrom
tipcommon_gitsync_1p
Open

TIPCommon update: Gitsync#515
gnishant-gupta wants to merge 18 commits intomainfrom
tipcommon_gitsync_1p

Conversation

@gnishant-gupta
Copy link
Contributor

@gnishant-gupta gnishant-gupta commented Jan 28, 2026

Checklist:

Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.

General Checks:

  • I have read and followed the project's contributing.md guide.
  • My code follows the project's coding style guidelines.
  • I have performed a self-review of my own code.
  • My changes do not introduce any new warnings.
  • My changes pass all existing tests.
  • I have added new tests where appropriate to cover my changes. (If applicable)
  • I have updated the documentation where necessary (e.g., README, API docs). (If applicable)

Open-Source Specific Checks:

  • My changes do not introduce any Personally Identifiable Information (PII) or sensitive customer data.
  • My changes do not expose any internal-only code examples, configurations, or URLs.
  • All code examples, comments, and messages are generic and suitable for a public repository.
  • I understand that any internal context or sensitive details related to this work are handled separately in internal systems (Buganizer for Google team members).

For Google Team Members and Reviewers Only:

  • I have included the Buganizer ID in the PR title or description (e.g., "Internal Buganizer ID: 123456789" or "Related Buganizer: go/buganizer/123456789").
  • I have ensured that all internal discussions and PII related to this work remain in Buganizer.
  • I have tagged the PR with one or more labels that reflect the pull request purpose.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gnishant-gupta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several updates and enhancements to the TIPCommon package. It includes version updates, new data models for representing SOAR entities, and updates to the API clients for interacting with various SOAR endpoints. These changes aim to improve the functionality and usability of the TIPCommon package.

Highlights

  • Version Update: The TIPCommon package version has been updated from 2.3.0 to 2.3.2 in pyproject.toml.
  • Data Model Enhancements: The IntegrationEnvironment data model now includes instance_description and is_configured attributes. The DynamicParameter data model now handles cases where key is missing, defaulting to dynamicParameterId, and provides to_json method.
  • New Data Models: Added new data models including Environment, IntegrationSetting, VisualFamily, OntologyRecord, CaseTag, Domain, CaseStage, CaseCloseReasons, CustomList, Blacklist, Network, SlaDefinition, SoarBlockEntity, and SimulatedCases to represent various system entities.
  • API Client Updates: The LegacySoarApi and OnePlatformSoarApi clients have been updated with new methods for interacting with various SOAR endpoints, including those for managing environments, integrations, cases, and settings.
  • SOAR API Enhancements: Added new functions to soar_api.py for retrieving and managing various SOAR entities, such as email templates, dynamic parameters, integration instances, domains, environments, cases, networks, custom lists, and more.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly expands the functionality of TIPCommon by adding numerous data models and API client methods. The changes are a positive step, particularly the move towards safer dictionary access using .get(). However, there are several areas that could be improved for robustness and maintainability. My review focuses on improving error handling by replacing broad except Exception blocks with more specific ones, correcting type hint mismatches, and addressing potential runtime errors to enhance code correctness. Addressing these points will make the new additions more reliable.

@github-actions github-actions bot added the Stale label Feb 20, 2026
gnishant-gupta and others added 2 commits February 25, 2026 07:55
Signed-off-by: gnishant <106644073+gnishant-gupta@users.noreply.github.com>
@github-actions github-actions bot removed the Stale label Feb 26, 2026
@gnishant-gupta gnishant-gupta marked this pull request as draft March 12, 2026 08:36
@gnishant-gupta gnishant-gupta marked this pull request as ready for review March 12, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants