Skip to content

Support new GoogleSecOpsProduct fields in integration metadata#636

Merged
TalShafir1 merged 9 commits intomainfrom
add-new-field-to-actions-meta
Apr 12, 2026
Merged

Support new GoogleSecOpsProduct fields in integration metadata#636
TalShafir1 merged 9 commits intomainfrom
add-new-field-to-actions-meta

Conversation

@TalShafir1
Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new IsFirstParty field to the integration metadata, allowing for better categorization of integrations. Alongside this functional enhancement, it includes routine updates to the project's version and various Python dependencies, ensuring the codebase remains current and benefits from the latest library improvements and security patches. A notable dependency change is the removal of rsa as a direct dependency for google-auth.

Highlights

  • New Feature: IsFirstParty Field: Added a new IsFirstParty boolean field to the integration metadata models (BuiltIntegrationMetadata, NonBuiltIntegrationMetadata, and IntegrationMetadata) to categorize integrations.
  • Dependency Updates: Updated multiple Python dependencies, including charset-normalizer, coverage, deepdiff, google-auth, google-genai, pyasn1, ruff, toon-format, ty, and uv to their latest versions. The rsa dependency was also removed from google-auth.
  • Project Version Bump: Incremented the project version from 1.28.20 to 1.28.21.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for a new IsFirstParty field in the integration metadata, which is reflected across the BuiltIntegrationMetadata, NonBuiltIntegrationMetadata, and IntegrationMetadata data models. The changes are mostly correct and consistent. However, I found a critical bug in metadata.py where a refactoring of a boolean check has inverted the logic for the is_available_for_community field, which could lead to data loss during serialization. I have provided a specific comment with a suggested fix for this issue.

Comment thread packages/mp/src/mp/core/data_models/integrations/integration_meta/metadata.py Outdated
@TalShafir1 TalShafir1 marked this pull request as ready for review March 22, 2026 11:00
@TalShafir1 TalShafir1 requested a review from a team as a code owner March 22, 2026 11:00
TalShafir1 and others added 2 commits March 22, 2026 13:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Tal Shafir <94114984+TalShafir1@users.noreply.github.com>
@AmitJ98 AmitJ98 added the mp mp related change label Mar 22, 2026
AmitJ98
AmitJ98 previously approved these changes Mar 22, 2026
@TalShafir1 TalShafir1 changed the title Support new IsFirstParty fields in integration metadata Support new GoogleSecOpsProduct fields in integration metadata Apr 12, 2026
@TalShafir1 TalShafir1 merged commit e495726 into main Apr 12, 2026
64 checks passed
@TalShafir1 TalShafir1 deleted the add-new-field-to-actions-meta branch April 12, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mp mp related change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants