Skip to content

XMLHttpRequest bug and Ionic Build Fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kayokwa wants to merge 2 commits into
base: master
Choose a base branch
from
Open

XMLHttpRequest bug and Ionic Build Fixes #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5faa31
Fixed bug - XMLHttpRequest status check
Dec 24, 2016
54c0809
Updated/Fixed Ionic build
Kayokwa Dec 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
"run:before": "build"
},
"dependencies": {
"ionic-native": "^2.0.3",
"ionicons": "^3.0.0",
"jquery": "^3.1.1",
"lodash": "^4.16.2",
"@angular/common": "2.1.1",
"@angular/compiler": "2.1.1",
"@angular/compiler-cli": "2.1.1",
Expand All @@ -27,11 +23,16 @@
"@angular/platform-browser-dynamic": "2.1.1",
"@angular/platform-server": "2.1.1",
"@ionic/storage": "1.1.6",
"ionic-angular": "2.0.0-rc.2"
"firebase": "^3.6.4",
"ionic-angular": "2.0.0-rc.2",
"ionic-native": "^2.0.3",
"ionicons": "^3.0.0",
"jquery": "^3.1.1",
"lodash": "^4.16.2"
},
"devDependencies": {
"@ionic/app-scripts": "0.0.39",
"@ionic/app-scripts": "0.0.47",
"@types/lodash": "4.14.36",
"typescript": "^2.0.3"
"typescript": "^2.0.10"
}
}
}
7 changes: 0 additions & 7 deletions src/app/main.prod.ts
View file
Open in desktop

This file was deleted.

0 src/app/main.dev.ts → src/app/main.ts
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion src/pages/login/login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export class LoginPage implements OnInit {
self.nav.setRoot(TabsPage);
}).catch(function (error) {
// Handle Errors here.
var errorCode = error.code;
var errorMessage = error.message;
loader.dismiss().then(() => {
let toast = self.toastCtrl.create({
Expand Down
5 changes: 2 additions & 3 deletions src/pages/signup/signup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ export class SignupPage implements OnInit {
});
}).catch(function (error) {
// Handle Errors here.
var errorCode = error.code;
var errorMessage = error.message;
console.error(error);
loader.dismiss().then(() => {
Expand All @@ -112,8 +111,8 @@ export class SignupPage implements OnInit {
xhr.open('GET', imageData, true);
xhr.responseType = 'blob';
xhr.onload = function (e) {
if (this.status === 200) {
var myBlob = this.response;
if (xhr.status === 200) {
var myBlob = xhr.response;
// myBlob is now the blob that the object URL pointed to.
self.startUploading(myBlob);
}
Expand Down